Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support node --enable-source-maps usage with our custom Error.prepareStackTrace usage #3833

Open
trentm opened this issue Jan 15, 2024 · 0 comments
Open

support node --enable-source-maps usage with our custom Error.prepareStackTrace usage #3833

trentm opened this issue Jan 15, 2024 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Jan 15, 2024

As of Node.js v21.6.0, node's internal prepareStackTrace function that handles source-map conversion for stack traces -- for the --enable-source-maps CLI option -- is exposed (as Error.prepareStackTrace).

That means that it should be possible chain our prepareStackTrace handling (which we use for parsing details from an exception for error reporting), with the core Node.js one when the user has used this CLI option.
@github-actions github-actions bot added the agent-nodejs Make available for APM Agents project planning. label Jan 15, 2024
@trentm trentm mentioned this issue Jan 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@trentm