Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration package to package spec v3 #11643

Closed
axw opened this issue Sep 14, 2023 · 4 comments · Fixed by #11822
Closed

Update integration package to package spec v3 #11643

axw opened this issue Sep 14, 2023 · 4 comments · Fixed by #11822
Assignees

Comments

@axw
Copy link
Member

axw commented Sep 14, 2023

elastic/package-spec#539

We should also add "apm" (and "observability"?) as a required capability for installing the package. See https://github.com/elastic/package-spec/blob/889754b93f7ee6f48651630dc4315cc59d43ec3b/spec/integration/manifest.spec.yml#L104-L119

@kyungeunni
Copy link
Contributor

This is currently blocked by this ticket. For the timebeing, it can be unblocked if the package-spec allows us to specify the mapping definition that has dynamic property in the manifest.yml, at least until we have the proper fix.

Before migrating, the following mapping was added to the template:

  "labels": {
    "type": "object",
    "dynamic": "true"
  },
  "numeric_labels": {
    "type": "object",
    "dynamic": "true"
  },

But with the latest version, it doesn't add this but only creates the dynamic_templates and it's causing an error like this:

.ds-metrics-apm.transaction.1m-default-2023.10.24-000001' (illegal_state_exception): Missing intermediate object numeric_labels"

cc @jsoriano @simitt

@simitt simitt added the blocked label Oct 30, 2023
@kyungeunni
Copy link
Contributor

It's unblocked thanks to the Fleet change: elastic/kibana#169981

@kyungeunni kyungeunni added blocked and removed blocked labels Nov 6, 2023
@kyungeunni
Copy link
Contributor

Mark it as blocked as we are depending on the Kibana snapshot that contains the change

@kyungeunni kyungeunni removed the blocked label Dec 8, 2023
@kyungeunni
Copy link
Contributor

kyungeunni commented Dec 11, 2023

#11822 is ready for reviews.

@simitt simitt removed this from the 8.12 milestone Jan 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants