Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TBS: "Value log GC request rejected" error #14305

Closed
carsonip opened this issue Oct 8, 2024 · 2 comments · Fixed by #14340
Closed

TBS: "Value log GC request rejected" error #14305

carsonip opened this issue Oct 8, 2024 · 2 comments · Fixed by #14340
Assignees

Comments

@carsonip
Copy link
Member

carsonip commented Oct 8, 2024

Errors observed in the wild: message "tail sampler aborted" with error.message "Value log GC request rejected".

Due to #14337 , it is possible to have 2 TBS GC goroutine running concurrently, which will cause one of them to crash. In a hot reload under EA, if the new server's GC crashed, and the old server's GC later stopped as part of the reload, this will leave the server with no GC and the TBS storage size will keep growing.

APM Server version (apm-server version): observed on 8.14.3

@carsonip carsonip added the bug label Oct 8, 2024
@carsonip carsonip changed the title TBS: "Value log GC request rejected" error crashing tail based sampling TBS: "Value log GC request rejected" error on shutdown Oct 8, 2024
@carsonip carsonip added enhancement and removed bug labels Oct 8, 2024
@carsonip carsonip changed the title TBS: "Value log GC request rejected" error on shutdown TBS: "Value log GC request rejected" error Oct 9, 2024
@carsonip
Copy link
Member Author

This should be caused by #14337 . Closing this issue to focus on fixing the root cause there.

@carsonip
Copy link
Member Author

However, there's one open question on under what circumstances will cleanup run before gc, as cleanup should always run after Execute.

The error is not due to cleanup before gc, but 2 concurrent gc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant