Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Github Action #224

Open
wants to merge 1 commit into
base: 8.13
Choose a base branch
from
Open

Update Github Action #224

wants to merge 1 commit into from

Conversation

ChristianeU
Copy link
Contributor

@ChristianeU ChristianeU commented Dec 6, 2024

Given that this is considered as "default" branch of this repository, I am updating the GitHub action, to reflect recent changes #221

Copy link
Member

@jmlrt jmlrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As previously mentioned I don't think we should consider 8.13 the default branch but work on recreating some main branch that should be the default branch or update the default branch to 8.16 and add a task in our bumping process to switch default branch each time we publish a new minor release.

@ChristianeU
Copy link
Contributor Author

ChristianeU commented Dec 10, 2024

@jmlrt Thank you, and yes, I agree with your suggestion as I found this a bit confusing from my previous work on the repo. I am not fully aware of why we have no main branch in this repo like others. I will focus on this after Milestone Release as it is out of the scope of my previous ticket that led to this discovery. So do you see value in updating this branch? I wanted to update it so I can compare it to latest branch 8.16, and from there set 8.16 as default of create main depending on which one will work best.

@ChristianeU ChristianeU requested a review from jmlrt December 10, 2024 16:28
@jmlrt
Copy link
Member

jmlrt commented Dec 10, 2024

@jmlrt Thank you, and yes, I agree with your suggestion as I found this a bit confusing from my previous work on the repo. I am not fully aware of why we have no main branch in this repo like others. I will focus on this after Milestone Release as it is out of the scope of my previous ticket that led to this discovery. So do you see value in updating this branch? I wanted to update it so I can compare it to latest branch 8.16, and from there set 8.16 as default of create main depending on which one will work best.

Let's merge this one, can you create a follow-up jira for setting a main branch or a process to always have the latest branch as default and we should be good 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants