Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove support from sklearn-based ESGradientBoostingModel in 9.0 #731

Open
pquentin opened this issue Oct 2, 2024 · 0 comments
Open

Remove support from sklearn-based ESGradientBoostingModel in 9.0 #731

pquentin opened this issue Oct 2, 2024 · 0 comments
Assignees
Labels
topic:ml Issue or PR about eland.ml.MLModel

Comments

@pquentin
Copy link
Member

pquentin commented Oct 2, 2024

With the move to Wolfi and the recent PyTorch/Transformers upgrade, we only have one CVE left in the Eland Docker image. The CVE itself is not that interesting and does not affect us, the point is more about not having any as part of our zero-CVE effort.

To fix it, we need to upgrade to scikit-learn 1.5 or above, while we're currently using 1.3 as there was a change in 1.4 to migrate from deviances to half losses. It's breaking us because we are importing those private, undocumented classes. Upgrading to scikit-learn isn't easy here - apparently there's at least a factor of 2 difference (hence the "Half" names) - but there could be other issues with the new version. That said, since we believe this feature has low usage, we would like to remove it:

  • Eland 8.16 (or earlier) should add a deprecation warning
  • Eland 9.0 should remove it.
@pquentin pquentin added the topic:ml Issue or PR about eland.ml.MLModel label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic:ml Issue or PR about eland.ml.MLModel
Projects
None yet
Development

No branches or pull requests

2 participants