Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helper for retrieving all search results using the recommended search after method? #1978

Closed
johann-petrak opened this issue Apr 30, 2022 · 2 comments

Comments

@johann-petrak
Copy link

There is currently the "scan" helper, which is built on top of scroll, but since scroll is not recommended any more,
should this not be built on top of search after? Or could there be a helper to allow users to easily retrieve all search
results in the proper order without having to deal with all those underlying implementation details of PIT, sort etc?

@ArnaudWald
Copy link

Hey there, I took the existing code for the scan helper, and re-wrote it using the point in time API.
Here's a gist of the finished helper: scan_pit.py

Haven't tested it extensively, only on my own setup and a couple of searches and it works similarly to what scan did (which was my intention).

Let me know if I can make a pull request to add this to the repo. Otherwise feel free to use it 😀

@sethmlarson
Copy link
Contributor

Going to close this as duplicate of #2072, thanks for your suggestion!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants