Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing the from parameter per issue #2385 #2421

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

JessicaGarson
Copy link

I removed the from parameter to fix the bug in the documentation reported here.

I also wanted to know if you knew of a good spot to add back to the description.

Copy link

A documentation preview will be available soon.

Help us out by validating the Buildkite preview and reporting issues here.
Please also be sure to double check all images to ensure they are correct in the preview.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@JessicaGarson JessicaGarson removed their assignment Jan 18, 2024
@pquentin
Copy link
Member

Hello! I really appreciate your efforts here, but unfortunately that code is generated, so that change will disappear at the next edit. I need to fix the generator, which is not public.

If you're still interested in working on the Elasticsearch client, maybe #2167 is a good fit? It involves a few changes in https://github.com/elastic/elastic-transport-python/. I can provide more explanations if needed. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants