Does NewBulkIndexer() needs an error return type in its return?

[shashank-boyapally]

I was unit testing my code, it was noticed that the return type NewBulkIndexer() is a BulkIndexer and error, but when looked into the NewBulkIndexer() code it just returns nil for error. Please let me know if NewBulkIndexer() needs an err as return. Below is the code snippet for from bulk_indexer.go. Please correct me if I'm wrong.

func NewBulkIndexer(cfg BulkIndexerConfig) (BulkIndexer, error) {
	if cfg.Client == nil {
		cfg.Client, _ = elasticsearch.NewDefaultClient()
	}

	if cfg.Decoder == nil {
		cfg.Decoder = defaultJSONDecoder{}
	}

	if cfg.NumWorkers == 0 {
		cfg.NumWorkers = runtime.NumCPU()
	}

	if cfg.FlushBytes == 0 {
		cfg.FlushBytes = 5e+6
	}

	if cfg.FlushInterval == 0 {
		cfg.FlushInterval = 30 * time.Second
	}

	bi := bulkIndexer{
		config: cfg,
		done:   make(chan bool),
		stats:  &bulkIndexerStats{},
	}

	bi.init()

	return &bi, nil
}

[HaraldNordgren]

Duplicate of #391.