Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tidylog function masking using ... means RStudio auto-complete and function definition help is not available. #56

Closed
orgadish opened this issue Nov 1, 2021 · 3 comments

Comments

@orgadish
Copy link
Contributor

orgadish commented Nov 1, 2021

tidylog has been hugely helpful for me in my data analysis workflows (thank you!). However, its masking of tidyr and dplyr functions using ... notation means that I can no longer use RStudio auto-complete for function arguments, or hover over the function name to see the arguments.

I used to use this all the time with pivot_wider and pivot_longer where I always forget names_to vs names_from, for example. Now in order to do this I have to explicitly type tidyr::pivot_wider( to start the autocomplete or search for the help.

Is there a way to perform the masking without replacing the help functionality?

@elbersb
Copy link
Owner

elbersb commented Nov 2, 2021

This came up before: #44. Unfortunately, I don't think there is a good solution for this. Tidylog could copy over the complete function signature from dplyr/tidyr, but that would be a nightmare to maintain.

@elbersb elbersb pinned this issue Feb 8, 2022
@orgadish
Copy link
Contributor Author

What would you think about copying the signature specifically for pivot_wider and pivot_longer as I think those are the ones which I would use the most. I would happily submit the PR for that (should be trivial).

@elbersb
Copy link
Owner

elbersb commented Sep 26, 2023

The problem with that approach is that if the signature of these functions ever changes, then the tidylog signature might be different from the signature that is actually in the function - and that would be a big mess. So unfortunately I still don't really have a good idea of how to solve this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants