-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
yett.unblock() conflicting with what-input.js / foundation modal #16
Comments
It's also conflicting with this date picker: https://codepen.io/mithicher/pen/VwvZaxm |
@DanielRuf @elbywan @ryhinchey @patrickhoehn |
Hi @sunilit42, not sure why you mentioned me. I am not actively involved in foundation anymore. The projects are now maintained by someone else. Best is you file a new bug report in the relevant repositories. |
@sunilit42 If anyone want to have a look, PRs are welcome but I doubt there is anything to be done on the |
@elbywan whitelist domain js execution happen from your js that is issue |
@sunilit42 This does not really mean anything, the whitelist can be configured by the user. As said, if you want to investigate PRs are welcome. Or just providing a real technical explanation about the issue would also be great. |
Hi thanks, for this awesome piece :)
I am using foundation's framework modal.
It works perfectly fine when yett is blocking other scripts.
The source is on the whitelist so also that works well.
However when I unblock the scripts with
yett.unblock();
I've found that yett.unblock() prevents whatinput.js to work properly.
So e.g. modal buttons / links do not fire anymore
The text was updated successfully, but these errors were encountered: