From 79eb973ff94b58c971251c1b5b000520f2d01e8e Mon Sep 17 00:00:00 2001 From: Abner Yang Date: Thu, 1 Aug 2024 23:10:53 -0400 Subject: [PATCH 1/4] Update README.md Use possessive instead of contraction --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 3cf50c5..2d55310 100644 --- a/README.md +++ b/README.md @@ -10,7 +10,7 @@ You get the full power of Wireshark with minimal impact on your running pods. ### Intro When working with micro-services, many times it's very helpful to get a capture of the network -activity between your micro-service and it's dependencies. +activity between your micro-service and its dependencies. ksniff use kubectl to upload a statically compiled tcpdump binary to your pod and redirecting it's output to your local Wireshark for smooth network debugging experience. From 12e0b1c92a503f21f2309acd32726137bdbc3a32 Mon Sep 17 00:00:00 2001 From: Abner Yang Date: Thu, 1 Aug 2024 23:13:34 -0400 Subject: [PATCH 2/4] Update README.md Keep same capitalized and period as rest of README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 2d55310..6d430df 100644 --- a/README.md +++ b/README.md @@ -94,7 +94,7 @@ Example using `tshark`: kubectl sniff pod-name -f "port 80" -o - | tshark -r - ### Contribution -More than welcome! please don't hesitate to open bugs, questions, pull requests +More than welcome! Please don't hesitate to open bugs, questions, pull requests. ### Future Work 1. Instead of uploading static tcpdump, use the future support of "kubectl debug" feature From ce7cb2668119d968004a535a0f09dca765e21b7a Mon Sep 17 00:00:00 2001 From: Abner Yang Date: Thu, 1 Aug 2024 23:14:39 -0400 Subject: [PATCH 3/4] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 6d430df..4d91b58 100644 --- a/README.md +++ b/README.md @@ -33,7 +33,7 @@ For manual installation, download the latest release package, unzip it and use t ### Wireshark -If you are using Wireshark with ksniff you must use at least version 3.4.0. Using older versions may result in issues reading captures (see [Known Issues](#known-issues) below). +If you are using Wireshark with ksniff, you must use at least version 3.4.0. Using older versions may result in issues reading captures (see [Known Issues](#known-issues) below). ## Build From 0c7d247e6cbbdf0fe8a62c9b24da4f1c81bbb29e Mon Sep 17 00:00:00 2001 From: Abner Yang Date: Thu, 1 Aug 2024 23:15:07 -0400 Subject: [PATCH 4/4] Update README.md Use possessive --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 4d91b58..7531728 100644 --- a/README.md +++ b/README.md @@ -12,7 +12,7 @@ You get the full power of Wireshark with minimal impact on your running pods. When working with micro-services, many times it's very helpful to get a capture of the network activity between your micro-service and its dependencies. -ksniff use kubectl to upload a statically compiled tcpdump binary to your pod and redirecting it's +ksniff use kubectl to upload a statically compiled tcpdump binary to your pod and redirecting its output to your local Wireshark for smooth network debugging experience. ### Demo