Fix apiVersion validation #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sya-ri Thanks for your contribution! I took the liberty to finally add some unit tests to the plugin to verify that everything works as expected c: I directly embedded your test cases as well. |
rainbowdashlabs
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for adding the
apiVersionvalidation! It was a great addition, but I noticed that it wasn't working correctly, so I fixed it.The issue was that the version separator was being processed as
\.instead of., causing incorrect behavior when splitting the version string.Additionally, I updated the validation logic to check the version format using a regular expression before splitting it.
Code & Error
Error
Changes
Tests
I tested the updated code in a scratch environment, and the results are now more accurate. Here are the test cases and their outputs:
Test Cases & Results
1.012^1\.[1-9][0-9]*(\.[1-9][0-9]*)?$1.121.131.191.201.20.31.20.41.20.51.20.61.211.021^1\.[1-9][0-9]*(\.[1-9][0-9]*)?$1.21.11.21.01^1\.[1-9][0-9]*(\.[1-9][0-9]*)?$1.21.1.^1\.[1-9][0-9]*(\.[1-9][0-9]*)?$2.1^1\.[1-9][0-9]*(\.[1-9][0-9]*)?$Let me know if you have any feedback! 🚀