-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: source of truth for version support #18
base: main
Are you sure you want to change the base?
Conversation
8f62b61
to
3cfeb30
Compare
"alpha": "2023-06-01", | ||
"beta": "2023-06-27", | ||
"stable": "2023-08-08", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dates shouldn't need to be hardcoded, they can be auto-generated from historical release data? Unless the intention is that these are date predictions, in which case I'm not a huge fan of this just living in a json file in this repo 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These dates shouldn't need to be hardcoded, they can be auto-generated from historical release data?
Fair point, I could look at making that change and generating them from the releases data.
Unless the intention is that these are date predictions, in which case I'm not a huge fan of this just living in a json file in this repo 🤔
For future versions (like 26 in this case) the alpha/beta/stable dates are added to e/e
as date "predictions" (AKA the schedule) via PRs like electron/electron#38378.
The point of them "just living in a json file in this repo" is they need to live somewhere (currently in that table in e/e
docs), and if they live here they can be used to generate that table in the docs instead, in addition to being generally available in machine-readable form for usage in automation.
One of the current main motivators of this PR is for the dates for the next release branch to be available in machine-readable form for the new release board automation on e/e
so it can fill in dates for when specific items need to be done by.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Idea which came up in the @~electron/wg-releases meeting today - what if alpha/beta/stable is auto-generated from historical data if those releases for that major have already happened (ignoring any hardcoded values) and uses the hardcoded "predictions" otherwise? Then as part of updating the scheduled dates for the next major version the PR would just cull the old dates for released versions (except for EOL).
in which case I'm not a huge fan of this just living in a json file in this repo 🤔
If this is the biggest concern, is there a spot you'd rather have it? I agree I'm not a huge fan of it being in this repo, but since this repo serves /releases.json
it seemed like the spot with the fewest moving pieces. If we'd rather we could put it somewhere in e/e
and have it grabbed (and cached) via octokit?
3cfeb30
to
ceb8a2c
Compare
ceb8a2c
to
b8bbe5d
Compare
🚧 Kicking this off for discussion.
Currently this information lives in a table in the
e/e
docs atdocs/tutorial/electron-timelines.md
, it was copied over directly (with dates tweaked to match expected format).This PR pulls that data into this repo and exposes a new
/support.json
and/versions.json
(which is just/support.json
+/releases.json
combined) to act as the single source of truth for this information. There are two generated fields,isSupported
(true if the major is not EOL) andisStable
(true if the vX.0.0 release exists for the major).Doing this lets us remove the hardcoding in this repo added in #15 to keep E22 as a stable release, since now that is dynamically determined by the EOL date in
src/versions-support.json
.🌎 The big picture idea is this information will be used in a bunch of places in downstream projects:
@electron/versions
package which takes theVersions
logic from@electron/fiddle-core
and refactors to use/versions.json
so that supported majors are not hardcoded@electron/versions
package and remove the duplicated logic we have with a hardcoded number of supported versions:electron/roller
electron/sudowoodo
electron/trop
electron/unreleased
electron/website
@electron/fiddle-core
and Fiddle to use@electron/versions
, ensuring that Fiddle accurately reflects supported majors/support.json
to pull the stable kickoff date when creating new release project boards one/e
@electron/fiddle-core
to find the latest stable release to using@electron/versions
electron/chromedriver
electron/mksnapshot
❓ Soliciting feedback on key names and the overall data shape here. Currently it's an array (similar to the existing
/releases.json
data shape) but it would also be reasonable to make it an object keyed by the major number, which is what Node.js does with their equivalent at https://github.com/nodejs/Release/blob/main/schedule.json.Here's what the output for a given major looks like: