FIX: elekto version in UI #102
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, thanks, lemme test this out. |
jberkus
reviewed
Nov 28, 2024
elekto/templates/layouts/app.html
Outdated
| @@ -49,6 +49,21 @@ | |||
| document.getElementById('message').hidden = true | |||
| }, 10000); | |||
| } | |||
| document.addEventListener('DOMContentLoaded', function () { | |||
| // Fetch the version from the Flask API | |||
| fetch('https://api.github.com/repos/elekto-io/elekto/releases/latest') | |||
There was a problem hiding this comment.
Am I reading this right? It seems to be pulling the latest version number from GitHub, rather than the version the user is actually running. Or did I miss something?
There was a problem hiding this comment.
my bad , i haven't thought through this
There was a problem hiding this comment.
should i run the bash script ' git describe --tags from the flask ' to get the current version?
now the current app version is fetched instead of latest version
|
@jberkus i made new approach to fetch the current version of the app use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #96
now the elekto version is displayed in the visible place