Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reply quote is present when editing a message #8612

Open
phorcys420 opened this issue Aug 16, 2023 · 7 comments
Open

Reply quote is present when editing a message #8612

phorcys420 opened this issue Aug 16, 2023 · 7 comments
Labels
A-Composer A-Replies O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems

Comments

@phorcys420
Copy link

phorcys420 commented Aug 16, 2023

Steps to reproduce

  1. Open a chat
  2. (Send a message)
  3. Reply to a message
  4. Edit the reply
  5. See

Outcome

What did you expect?

I expected that the content that appears in the edit box would only be the reply text.

What happened instead?

The edit box also contained the "From" and original text (see video)

Your phone model

Google Pixel 6a

Operating system version

Android 13 (TQ3A.230705.001)

Application version and app store

Element 1.6.5 [40106052] (G-fd6a45a3), Rust SDK 0.6.0 (3fd55c0), Vodozemac 0.4.0 from Play Store

Homeserver

Synapse 1.85.2

Will you send logs?

No

Are you willing to provide a PR?

Yes

@phorcys420 phorcys420 added the T-Defect Something isn't working: bugs, crashes, hangs and other reported problems label Aug 16, 2023
@julioromano julioromano added A-Replies A-Composer S-Tolerable Low/no impact on users O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Aug 28, 2023
@Palloxin
Copy link

Palloxin commented Sep 5, 2023

YouCut_20230905_101840924.mp4

A video reproduction of the bug.
Android 8

@phorcys420
Copy link
Author

I thought it was clear, but I did already include a video in my issue!
In the "What happened?" section.

@Palloxin
Copy link

Palloxin commented Sep 5, 2023

It says "Not found". Not sure if it is only me
IMG_20230905_124032

@pludi
Copy link

pludi commented Sep 12, 2023

Sounds like the same issue as in #8602

@phorcys420
Copy link
Author

phorcys420 commented Sep 12, 2023

It says "Not found". Not sure if it is only me

Oh yeah, you're right!
Sorry.

Sounds like the same issue as in #8602

I'm unsure given that #8602 only mentions text displaying issues.

@pludi
Copy link

pludi commented Sep 12, 2023

Sounds like the same issue as in #8602

I'm unsure given that #8602 only mentions text displaying issues.

Below the first screenshots there's a section about "duplicate in reply to …:"

@Luka5W
Copy link

Luka5W commented Sep 13, 2023

yep. its addressed in my issue and fixed in my pull request. its very annoying and has been there for a while (#8377) now. no idea how this commit could pass the QA. can't believe that no one has fixed this/ has noticed this behavior.

but features > stable app i guess 🤡 and its only a major feature to edit replies/ markdown messages so... the label O-Uncommon and S-ToLeRaBlE is completely appropiate here 🤡 🤡 🤡

btw. i would think twice if you put any effort in this project... im not sure if i will if my pr isnt accepted without bigger change requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-Composer A-Replies O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Low/no impact on users T-Defect Something isn't working: bugs, crashes, hangs and other reported problems
Projects
None yet
5 participants