Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manal upgrade to prettier 3.4.2 #2037

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Manal upgrade to prettier 3.4.2 #2037

merged 1 commit into from
Dec 11, 2024

Conversation

dbkr
Copy link
Member

@dbkr dbkr commented Dec 10, 2024

Including the reformatting changes needed to make it pass again (mostly due to prettier/prettier#15526).

Checklist

  • Ensure your code works with manual testing.
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • I have licensed the changes to Element by completing the Contributor License Agreement (CLA)

Including the reformatting changes needed to make it pass again
(mostly due to prettier/prettier#15526).
@dbkr dbkr added the T-Task Tasks for the team like planning label Dec 10, 2024
@dbkr dbkr requested review from a team as code owners December 10, 2024 17:57
version "3.3.3"
resolved "https://registry.yarnpkg.com/prettier/-/prettier-3.3.3.tgz#30c54fe0be0d8d12e6ae61dbb10109ea00d53105"
integrity sha512-i2tDNA0O5IrMO757lfrdQZCc2jPNDVntV0m/+4whiDfWaTKfMNgR7Qz0NAeGz/nRqF4m5/6CLzbP4/liHt12Ew==
version "3.4.2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason to not have this version in package.json as well?

Copy link
Member Author

@dbkr dbkr Dec 11, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just letting yarn upgrade do its thing really, plus its what renovate does. Nothing actually requires the newer version so it feels like an accurate description of the world.

@dbkr dbkr merged commit 9327447 into develop Dec 11, 2024
43 checks passed
@dbkr dbkr deleted the dbkr/prettier342 branch December 11, 2024 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants