Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Story] Accepting & declining requests to join #2580

Open
2 of 4 tasks
mxandreas opened this issue Oct 16, 2024 · 3 comments
Open
2 of 4 tasks

[Story] Accepting & declining requests to join #2580

mxandreas opened this issue Oct 16, 2024 · 3 comments

Comments

@mxandreas
Copy link

mxandreas commented Oct 16, 2024

Description

Accepting an individual request

  • As an admin who is managing access to a room
  • I want to accept a request from a person who eligible to join
  • So that they can join the room

Accepting all requests

  • As an admin who is managing access to a room
  • I want to accept all the pending requests at once when they look eligible
  • So that managing large amounts of requests is less effort for me

Declining an individual request

  • As an admin who is managing access to a room
  • I want to decline a request from a person who is not eligible to join
  • So that they would not be able to join

Declining an individual request & banning the person

  • As an admin who is managing access to a room
  • I want to stop a person requesting access to a room
  • So that I do not constantly have to deal with their (spamming) requests

Conditions:

  • The admin here is a user with invite or kick permissions on the room;
    • Should the room permissions have been adjusted so that the admin has only invite - the admin is only able to Accept but not Decline (the Decline button is not shown).
    • Likewise if the admin has only kick - the admin is only able to Decline (the Accept button is not shown).
    • Also, the Decline & ban button is only shown if the admin has both kick & ban permissions on the room.
  • Should the request be cancelled by the requester just before its accepted or declined (e.g. technically accept/decline fails because of this), this is hidden from the user - e.g. no need to tell the user that “technically” it failed.

Designs:

Acceptance criteria

  • When a request is successfully accepted, the requester receives an invite to join the room.
  • When a request is successfully declined, the pending request disappears for the requester.
  • When a request is successfully declined & user is banned, the user can no longer request access to the room.
  • TBC: should the above work also when meanwhile room's join rule has changed.

Size estimate

None

Dependencies

  • None

Out of scope

  • Nothing

Open questions

Questions

Subtasks

Android

No tasks being tracked yet.

iOS

No tasks being tracked yet.

Rust

No tasks being tracked yet.

Other

  1. A-Sync
@mxandreas
Copy link
Author

@ganfra @gaelledel We had a discussion with @Velin92 and @jmartinesp that we should also have an option to ban the user when their request is being declined. I am afraid that this is going to cause friction if we do not have it. Fortunately, this is easy to do from engineering side, so the only thing is to see how to fit this into the designs, e.g. perhaps just have 3rd option "Decline & ban" in the confirmation modal.

@mxandreas
Copy link
Author

@ganfra @gaelledel We had a discussion with @Velin92 and @jmartinesp how to remember if the admin/moderator has seen a request in the room (in the banner) and has dismissed/postponed it. We have to remember it, to make sure that the banner does not come up multiple times for the same request.

It is largely a technical question, however, depending on the solution, the behavior may differ for the user a bit:

  • We remember it locally in the app - meaning that if the admin/moderator has other apps, they are still seeing the banner in there.
  • We remember it globally in the account data - meaning that if the admin/moderator dismisses a request in one app, it will not show up in the others.

If there is no major difference in effort then the global solution is preferred.

@mxandreas
Copy link
Author

Concluded that we will have the option to Decline & Ban - Gaelle is adding the designs now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant