Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Notification keywords match on usernames #743

Open
kittykat opened this issue Nov 3, 2021 · 2 comments
Open

Notification keywords match on usernames #743

kittykat opened this issue Nov 3, 2021 · 2 comments
Labels
A-Notifications A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Spec-Changes

Comments

@kittykat
Copy link
Contributor

kittykat commented Nov 3, 2021 •
edited by MadLittleMods
Loading

Steps to reproduce

  1. Have a "kat" keyword set up in the notifications panel
  2. Have someone reply to a post by someone else whose username/MXID contains "kat"
  3. Be notified

I am not sure if this is a bug or really an enhancement request

Outcome

What did you expect?

Matching is only on content, not on usernames. I can see how username matching may be useful, but there are a lot of people out there with the same name so maybe it should be optional.

What happened instead?

I got a lot of notifications which did not @ me and did not contain anything that was related to me as far as I could see

Screenshot from 2021-11-03 09-17-13

Operating system

No response

Browser information

No response

URL for webapp

develop.element.io

Application version

Element version: f9cbdb8aa05e-react-801eb068d69b-js-50332c4999f0 Olm version: 3.2.3

Homeserver

No response

Will you send logs?

No
@kittykat kittykat added T-Defect S-Major Severely degrades major functionality or product features, with no satisfactory workaround A-User-Settings A-Notifications O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Nov 3, 2021
@MadLittleMods MadLittleMods mentioned this issue Oct 12, 2022
Closed
@MadLittleMods
Copy link

MadLittleMods commented Oct 12, 2022 •
edited
Loading

Related to element-hq/element-web#16863, #744

@t3chguy
Copy link
Member

t3chguy commented Oct 13, 2022

Clients & servers apply push rule matching based on the spec

@t3chguy t3chguy transferred this issue from element-hq/element-web Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Notifications A-User-Settings O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Major Severely degrades major functionality or product features, with no satisfactory workaround T-Defect X-Spec-Changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kittykat @MadLittleMods @t3chguy