Remove abandoned Voice Broadcasts labs flag #28548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any existing voice broadcasts will be shown as a series of voice messages which will sequence play as normal Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
dbkr
approved these changes
Nov 26, 2024
|
Plan of removal has been shared with the company and mgmt and no push back - go for it Obvs I can't review code but from a product pov, adding a tick! |
daniellekirkwood
approved these changes
Nov 28, 2024
…to t3chguy/remove-voice-broadcasts # Conflicts: # test/unit-tests/events/EventTileFactory-test.ts # test/unit-tests/stores/RoomViewStore-test.ts # test/unit-tests/voice-broadcast/components/VoiceBroadcastBody-test.tsx # test/unit-tests/voice-broadcast/models/VoiceBroadcastPlayback-test.tsx # test/unit-tests/voice-broadcast/utils/hasRoomLiveVoiceBroadcast-test.ts # test/unit-tests/voice-broadcast/utils/isRelatedToVoiceBroadcast-test.ts # test/unit-tests/voice-broadcast/utils/retrieveStartedInfoEvent-test.ts
auto-merge was automatically disabled
December 2, 2024 09:35
Pull request was closed
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
…to t3chguy/remove-voice-broadcasts # Conflicts: # test/unit-tests/TestSdkContext.ts # test/unit-tests/components/views/rooms/MessageComposer-test.tsx
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any existing voice broadcasts will be shown as a series of voice messages which will sequence play as normal
I suggest glossing over all the removed files and looking at the changed files predominantly. This feature was unexpectedly gigantic.