-
-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove usages of Buffer so we don't need to ship the polyfill #28626
Conversation
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
Signed-off-by: Michael Telatynski <[email protected]>
…to t3chguy/web-friendly-buffers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, although why the clamped arrays?
That's the signature coming out of rust crypto for QR codes, rather than having to convert on both sides it makes sense to just use the right type to begin with The js-sdk was previously doing stuff like this and it just made no sense, I guess for intercompat with Node's Buffer which can be used interchangeably Much cleaner to just deal with the right type in the first place |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, fair enough - looks like it's probably the type that the wasm bindings pick by default I guess.
For matrix-org/matrix-js-sdk#4569
Looks like we cannot get rid of Buffer entirely as https://www.npmjs.com/package/bloom-filters requires Buffers until Callidon/bloom-filters#70