Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate-Limiting for set_presence changes #16705

Open
matrixbot opened this issue Dec 21, 2023 · 2 comments · May be fixed by #18000
Open

Rate-Limiting for set_presence changes #16705

matrixbot opened this issue Dec 21, 2023 · 2 comments · May be fixed by #18000

Comments

@matrixbot
Copy link
Collaborator

matrixbot commented Dec 21, 2023

This issue has been migrated from #16705.


Description:

I notice that within the last few days (probably with a new version of Element Desktop) these clients start flooding my synapse server with presence changes if there are multiple sessions.
I observed over 30+ presence requests per second from single clients, giving noticeable load on the server.
These are changes which are flipping between set_presence=online and set_presence=unavailable.
This might be a bug somewhere in Element or Synapse at the moment, but a rogue client could deliberately flood the server with presence changes which then can render it completely unusable.
There should be a rate-limiting applied for presence updates per user or per session in order to prevent this.

@matrixbot matrixbot changed the title Dummy issue Rate-Limiting for set_presence changes Dec 22, 2023
@matrixbot matrixbot reopened this Dec 22, 2023
@jlemangarin
Copy link

Still HARD flooding the browser and the server
1.98.0

@ChristophWolffNabu
Copy link

Still problem in 1.11.83

@rda0 rda0 linked a pull request Dec 5, 2024 that will close this issue
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants