Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bust _membership_stream_cache cache when current state changes #17368

Open
MadLittleMods opened this issue Jun 27, 2024 · 0 comments · May be fixed by #17732
Open

Bust _membership_stream_cache cache when current state changes #17368

MadLittleMods opened this issue Jun 27, 2024 · 0 comments · May be fixed by #17732
Assignees
@MadLittleMods
Labels
A-Sync z-bug

Comments

@MadLittleMods
Copy link
Contributor

Spawning from #17320 (comment)

Bust _membership_stream_cache cache when current state changes.

Currently, the only reference I can find is in CacheInvalidationWorkerStore._invalidate_caches_for_event(...) which doesn't handle current state changing.

Dev notes

This is where we should be adding the cache busting:

synapse/synapse/storage/databases/main/cache.py

Line 266 in 956f20e

elif row.type == EventsStreamCurrentStateRow.TypeId:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadLittleMods MadLittleMods

Labels
A-Sync z-bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Bust _membership_stream_cache cache when current state changes element-hq/synapse
1 participant
@MadLittleMods