Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sliding Sync: Avoid fetching left rooms and add back newly_left rooms #17725

Merged
merged 17 commits into from
Sep 19, 2024
Merged

Sliding Sync: Avoid fetching left rooms and add back newly_left rooms #17725

merged 17 commits into from
Sep 19, 2024

Commits on Sep 17, 2024

  1. First pass of not fetching left rooms and adding back newly_left

    @MadLittleMods
    MadLittleMods committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    87c844a View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. event_id/sender can be None in non-state reset scenarios

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    fcee1a6 View commit details
    Browse the repository at this point in the history

  2. Fix state reset vs server no longer participating in room case

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e221924 View commit details
    Browse the repository at this point in the history

  3. Fix room subscription for left room

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    8b989b3 View commit details
    Browse the repository at this point in the history

  4. Fix popping room

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    689905e View commit details
    Browse the repository at this point in the history

  5. Add changelog

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    d1b7164 View commit details
    Browse the repository at this point in the history

  6. Make sure we can see newly_left from state reset

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    72ccdeb View commit details
    Browse the repository at this point in the history

  7. Add test assertions

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    37478fb View commit details
    Browse the repository at this point in the history

  8. Fix state reset when filtering

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    f078df7 View commit details
    Browse the repository at this point in the history

  9. Fix fallback path

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    a894e3b View commit details
    Browse the repository at this point in the history

  10. Remove debug logs

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    b5a96b7 View commit details
    Browse the repository at this point in the history

  11. Fix wrong room being referenced

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    4520031 View commit details
    Browse the repository at this point in the history

  12. No longer need to filter_membership_for_sync 

    We already don't fetch self-leaves and add back `newly_left`
    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    0e4d08f View commit details
    Browse the repository at this point in the history

  13. Better test required_state during state reset

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    e06acd2 View commit details
    Browse the repository at this point in the history

  14. Test when we never sent a state reset room down before

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ff85e5b View commit details
    Browse the repository at this point in the history

  15. Better test never send down connection rooms in state reset scenarios

    @MadLittleMods
    MadLittleMods committed Sep 18, 2024
    Configuration menu
    Copy the full SHA
    ff8e8fb View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2024

  1. Merge remote-tracking branch 'origin/develop' into madlittlemods/slid… 

    …ing-sync-add-back-newly-left
    @erikjohnston
    erikjohnston committed Sep 19, 2024
    Configuration menu
    Copy the full SHA
    ecc3b37 View commit details
    Browse the repository at this point in the history