From 5a6d46ab733118362ae520b8e24988bbccf15942 Mon Sep 17 00:00:00 2001 From: IDoneShaveIt Date: Mon, 5 Feb 2024 15:40:13 +0200 Subject: [PATCH] ELE-2444 - add logs for Slack alerts sending errors --- .../alerts/integrations/slack/slack.py | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py b/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py index 1abc740f3..6184ee8ac 100644 --- a/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py +++ b/elementary/monitor/data_monitoring/alerts/integrations/slack/slack.py @@ -28,6 +28,10 @@ from elementary.utils.json_utils import ( list_of_lists_of_strings_to_comma_delimited_unique_strings, ) +from elementary.utils.log import get_logger + +logger = get_logger(__name__) + TABLE_FIELD = "table" COLUMN_FIELD = "column" @@ -954,7 +958,10 @@ def send_alert( sent_successfully = self.client.send_message( channel_name=channel_name, message=template ) - except Exception: + except Exception as err: + logger.error( + f"Unable to send alert via Slack: {err}\nSending fallback template." + ) sent_successfully = False if not sent_successfully: @@ -963,7 +970,8 @@ def send_alert( fallback_sent_successfully = self.client.send_message( channel_name=channel_name, message=fallback_template ) - except Exception: + except Exception as err: + logger.error(f"Unable to send alert fallback via Slack: {err}") fallback_sent_successfully = False self.message_builder.reset_slack_message() return fallback_sent_successfully