Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-1699 Setup multi-platform Docker images to support both x86 and arm architectures #1701

Merged

Conversation

JanDintel
Copy link

@JanDintel JanDintel commented Sep 10, 2024

Introduction

Support multiple platforms (architectures) for the Docker container in the Github Action release.

In this way open-source users can run the Docker image on both x86 and arm architectures. Rational behind this is because more cloud providers are supporting arm architectures with provide a better price-performance.

Closed GH-1699

Supporting documentation

@JanDintel JanDintel changed the title Setup multi-platform Docker images to support both x86 and arm architures #1699 Setup multi-platform Docker images to support both x86 and arm architures Sep 10, 2024
@JanDintel JanDintel changed the title #1699 Setup multi-platform Docker images to support both x86 and arm architures GH-1699 Setup multi-platform Docker images to support both x86 and arm architures Sep 10, 2024
@JanDintel JanDintel changed the title GH-1699 Setup multi-platform Docker images to support both x86 and arm architures GH-1699 Setup multi-platform Docker images to support both x86 and arm architectures Sep 10, 2024
@ofek1weiss ofek1weiss self-assigned this Sep 23, 2024
@ofek1weiss
Copy link
Contributor

Hey @JanDintel , looks great 🚀
make sure to update your branch with master and ill make sure it is merged 😁

@ofek1weiss
Copy link
Contributor

@JanDintel Just one thing, looks like in the empty lines you added, there are whitespaces which our code quality check does not seem to like, make sure to remove those

@JanDintel
Copy link
Author

@ofek1weiss thank you for the review!
I've updated the file to remove the unnecessary white spacing and the previously failing pre-commit hook for prettier passed locally.

@ofek1weiss ofek1weiss merged commit 0f4a215 into elementary-data:master Sep 23, 2024
2 checks passed
@ofek1weiss
Copy link
Contributor

@JanDintel 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for arm architecture in the published docker image
2 participants