Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Boolean Parsing for ENABLE_OPEN_AI_COMMUNITY_PLUGIN Setting #2559

Closed
lincheoll opened this issue Jan 20, 2025 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@lincheoll
Copy link
Contributor

Describe the bug
There was an issue with loading the ENABLE_OPEN_AI_COMMUNITY_PLUGIN setting. Regardless of whether true or false was set, the value was always interpreted as a string, causing the setting to always be enabled.

To Reproduce
Steps to reproduce the behavior:

Set ENABLE_OPEN_AI_COMMUNITY_PLUGIN to true or false in the configuration.
Run the application.
Observe that the feature is always enabled, regardless of the intended value.
Expected behavior
The feature should only be enabled when ENABLE_OPEN_AI_COMMUNITY_PLUGIN is set to true. When set to false, the feature should remain disabled.

Screenshots

Additional context
I will fix it

@lincheoll lincheoll added the bug Something isn't working label Jan 20, 2025
lincheoll added a commit to lincheoll/eliza that referenced this issue Jan 20, 2025
lincheoll added a commit to lincheoll/eliza that referenced this issue Jan 21, 2025
lincheoll added a commit to lincheoll/eliza that referenced this issue Jan 21, 2025
wtfsayo added a commit that referenced this issue Jan 21, 2025
…ting #2559 (#2560)

* fix: Incorrect boolean parsing for ENABLE_OPEN_AI_COMMUNITY_PLUGIN setting #2559

* fix: boolean parsing for openai plugin (#2559)

---------

Co-authored-by: Sayo <[email protected]>
0xrubusdata pushed a commit to 0xrubusdata/eliza that referenced this issue Jan 21, 2025
…ting elizaOS#2559 (elizaOS#2560)

* fix: Incorrect boolean parsing for ENABLE_OPEN_AI_COMMUNITY_PLUGIN setting elizaOS#2559

* fix: boolean parsing for openai plugin (elizaOS#2559)

---------

Co-authored-by: Sayo <[email protected]>
@tcm390
Copy link
Collaborator

tcm390 commented Jan 22, 2025

fixed in #2560

@tcm390 tcm390 closed this as completed Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants