Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker is preferred over global php & phpunit (and also doesn't work out-of-the-box) #117

Open
sm11963 opened this issue Sep 20, 2024 · 0 comments

Comments

@sm11963
Copy link

sm11963 commented Sep 20, 2024

Repro

  1. Patch Fix ComposerDriver isInstalled falsy check #116 OR order ComposerDriver to the end of the list
  2. Only have php installed globally.
  3. Only have phpunit globally available in PATH (for me this is in ~/bin/phpunit)
  4. Have docker installed on your machine
  5. Try to run tests with the extension

Outcome

Test run failed with output:

 *  Executing task: docker run --rm -t -v ${pwd}:/app -w /app php php phpunit --colors=always --filter 'MathExpressionTest' '/app/modules/tests/MathExpressionTest.php' 

docker: invalid spec: :/app: empty section between colons.
See 'docker run --help'.

 *  The terminal process "/bin/zsh '-l', '-c', 'docker run --rm -t -v ${pwd}:/app -w /app php php phpunit --colors=always --filter 'MathExpressionTest' '/app/modules/tests/MathExpressionTest.php''" failed to launch (exit code: 125). 
 *  Terminal will be reused by tasks, press any key to close it. 

Expected outcome

Tests run successfully given I have php and phpunit globally available.

OR the docker command executes successfully, that would also work - but I would kind of expect global values to be used before docker. Especially since I see that some docker config is deprecated.

Logs / output / settings

Settings all at default if you applied #116, otherwise, you need to set ComposerDriver to the end of the order.

Environment Values
Extension version 4.16.1 with #116
Operating system MacOs 14.6.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant