Skip to content
This repository has been archived by the owner on Mar 27, 2019. It is now read-only.

Directionality check for Username profiles #8

Open
legastero opened this issue May 3, 2016 · 1 comment
Open

Directionality check for Username profiles #8

legastero opened this issue May 3, 2016 · 1 comment

Comments

@legastero
Copy link
Contributor

The Username profiles are currently always applying the Bidi rule, but the RFC says the Bidi rule only needs to be satisfied if there are any RTL characters present.

Right now, a username that looks like "5example" will fail because the leading 5 violates the first condition of the Bidi rule (it has a Bidi class of EN, not L, R, or AL).

@ezzatron
Copy link
Collaborator

ezzatron commented May 4, 2016

Thanks for the heads up! Should be fairly simple to fix, but I don't have a lot of spare time for this project at the moment. If you need it anytime soon, a PR is your best bet.

Side note, there are still some serious issues with precis-js, brought up in #1, and further documented in #6 and #7. Not related to this issue, but just making sure you're aware if you were looking at using this library in production code. Cheers.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants