Skip to content
This repository has been archived by the owner on Dec 17, 2024. It is now read-only.

Event dispatcher is breaking Pretty formatter #61

Open
marcelovani opened this issue Jan 17, 2023 · 1 comment
Open

Event dispatcher is breaking Pretty formatter #61

marcelovani opened this issue Jan 17, 2023 · 1 comment

Comments

@marcelovani
Copy link
Contributor

marcelovani commented Jan 17, 2023 •
edited
Loading

This code https://github.com/elvetemedve/behat-screenshot/pull/59/files#diff-367a0438232ae30182922c4e9618bd66be531f661c4e57d09b710749010b7fb9R6 is causing issues and the Pretty formatter or Progress formatter are not working.

I started to work on a fix #62
marcelovani added a commit to marcelovani/behat-screenshot that referenced this issue Jan 17, 2023
@marcelovani
elvetemedve#61: Using namespace to avoid conflicts.
3bf921c
marcelovani added a commit to marcelovani/behat-screenshot that referenced this issue Jan 17, 2023
@marcelovani
elvetemedve#61: Using namespace to avoid conflicts.
e48b7c8
@marcelovani marcelovani changed the title Event dispatcher is breaking Pretty formatter WIP: Event dispatcher is breaking Pretty formatter Jan 17, 2023
@marcelovani
Copy link
Contributor Author

Using the namespace makes the Pretty formatter work, but the event no longer works :( need to go back to the drawing board

@marcelovani marcelovani changed the title WIP: Event dispatcher is breaking Pretty formatter Event dispatcher is breaking Pretty formatter Jan 17, 2023
marcelovani added a commit to marcelovani/behat-screenshot that referenced this issue Jan 19, 2023
@marcelovani
elvetemedve#61: Implementation using static cache.
fcbc7cc
marcelovani added a commit to marcelovani/behat-screenshot that referenced this issue Jan 19, 2023
@marcelovani
elvetemedve#61: Removed event.
078dba5
marcelovani added a commit to marcelovani/behat-screenshot that referenced this issue Jan 19, 2023
@marcelovani
elvetemedve#61: Removed event.
a9b2716
marcelovani added a commit to marcelovani/behat-screenshot that referenced this issue Jan 19, 2023
@marcelovani
elvetemedve#61: Fixed indentation.
f310693
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcelovani