Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code refactoring: make the extension code ES6 compatible #37

Open
elvetemedve opened this issue Sep 9, 2017 · 2 comments
Open

Code refactoring: make the extension code ES6 compatible #37

elvetemedve opened this issue Sep 9, 2017 · 2 comments

Comments

@elvetemedve
Copy link
Owner

GJS has made many changes to be ES6 compatible. The extension code should follow it and use the new syntax wherever it is possible.

GJS changes are presented here: https://speakerdeck.com/ptomato/modern-javascript-in-gnome

@genodeftest
Copy link
Contributor

As an example, gnome-shell 3.26.1 prints many warnings like this one:

Some code accessed the property 'STORAGE_METER' on the module 'prefs_keys'. That property was defined with 'let' or 'const' inside the module. This was previously supported, but is not correct according to the ES6 standard. Any symbols to be exported from a module must be defined with 'var'. The property access will work as previously for the time being, but please fix your code anyway.

@elvetemedve
Copy link
Owner Author

Yep, I know it prints a bunch of warnings, but fortunately the extension seems to be working.
I'll have more free time in November when I want to fix all of these.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants