Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DRY up auth testing #144

Open
Dhaulagiri opened this issue Feb 12, 2018 · 3 comments
Open

DRY up auth testing #144

Dhaulagiri opened this issue Feb 12, 2018 · 3 comments

Comments

@Dhaulagiri
Copy link
Collaborator

Dhaulagiri commented Feb 12, 2018 •
edited by elwayman02
Loading

Currently we have a lot of repeated code in acceptance tests confirm the auth token is sent with requests. This seems like the wrong level to be testing this as the acceptances are really just confirming that injecting the token into the adapter works which could be tested at a lower level once?

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.
@Dhaulagiri Dhaulagiri mentioned this issue Feb 12, 2018
Open
@elwayman02
Copy link
Owner

Agreed, seems better to just test the inject in a single place

@Dhaulagiri
Copy link
Collaborator Author

The injection is tested at the adapter level here, I wonder if it matters at all to also test in acceptance tests?

@elwayman02
Copy link
Owner

Probably not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elwayman02 @Dhaulagiri