-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release 0.9.7 is missing package-lock.json #252
Comments
Oh sorry. I didn't know it was used in the Nix package. I'll add it ASAP when the PC is available. 😔 |
Added the |
Awesome thank you @jcs090218 |
@jcs090218 if possible would you be able to cut a 7.5.1 release with the included lock? |
I have cut a release |
@jcs090218 no it doesn't. The source code tar.gz appears to have a code from Apr 15. Not the latest one and it doesn't have package-lock.json. Sorry for causing a pain. |
I reckon it's because the tag was created on April 15th and it's used as an archive. |
Just to confirm the version from master branch builds as expected, so as soon as we have a tag with package-lock.json included we bump nixpkg version. |
I assumed |
@jcs090218 yes please. It doesn't because you created a tag on April 15th. It's when the archive is created not when you create a release. At least at the moment. Have a look at timestamps of files in the release notes. |
I got it! I've published a new release, 0.9.9. It should contain a |
@jcs090218 thank you builds with the tag 🎉 |
Hi @jcs090218,
I was trying to update a nix package for the CLI, but the release is missing package-lock.json.
Any chance you could include it in the upcoming release?
It was removed in #218
The text was updated successfully, but these errors were encountered: