Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.9.7 is missing package-lock.json #252

Closed
piotrkwiecinski opened this issue Jun 2, 2024 · 12 comments
Closed

Release 0.9.7 is missing package-lock.json #252

piotrkwiecinski opened this issue Jun 2, 2024 · 12 comments
Labels
bug Something isn't working

Comments

@piotrkwiecinski
Copy link

piotrkwiecinski commented Jun 2, 2024

Hi @jcs090218,
I was trying to update a nix package for the CLI, but the release is missing package-lock.json.
Any chance you could include it in the upcoming release?

It was removed in #218

@jcs090218
Copy link
Member

Oh sorry. I didn't know it was used in the Nix package. I'll add it ASAP when the PC is available. 😔

@jcs090218
Copy link
Member

Added the package-lock.json file back in 1ff49ac. :)

@jcs090218 jcs090218 added the bug Something isn't working label Jun 2, 2024
@piotrkwiecinski
Copy link
Author

Awesome thank you @jcs090218

@piotrkwiecinski
Copy link
Author

@jcs090218 if possible would you be able to cut a 7.5.1 release with the included lock?

@jcs090218
Copy link
Member

I have cut a release 0.9.8; does that work for you? 🤔

@piotrkwiecinski
Copy link
Author

@jcs090218 no it doesn't. The source code tar.gz appears to have a code from Apr 15. Not the latest one and it doesn't have package-lock.json. Sorry for causing a pain.

@piotrkwiecinski
Copy link
Author

I reckon it's because the tag was created on April 15th and it's used as an archive.

@piotrkwiecinski
Copy link
Author

Just to confirm the version from master branch builds as expected, so as soon as we have a tag with package-lock.json included we bump nixpkg version.

@jcs090218
Copy link
Member

I assumed 0.9.8 doesn't contain the package-lock.json file. Should I cut one more release? 🤔

@piotrkwiecinski
Copy link
Author

@jcs090218 yes please. It doesn't because you created a tag on April 15th. It's when the archive is created not when you create a release. At least at the moment. Have a look at timestamps of files in the release notes.

@jcs090218
Copy link
Member

I got it! I've published a new release, 0.9.9. It should contain a package-lock.json file.

@piotrkwiecinski
Copy link
Author

@jcs090218 thank you builds with the tag 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants