-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dap-node setup seems broken #554
Comments
This is dos protection. Issue should go away after some time. |
My |
@mihaiolteanu it is related. I fixed it by downloading the extension manually and extracting it in the destination directory. |
I got the same issue when running the Lines 70 to 78 in 76cad34
For me, the generated URL was:
Or this one:
I think the |
This issue persists. I came to the same conclusion as @abougouffa by following the broken url. I have updated dap-mode just now and the problem is still there. |
On my machine it's ~/.emacs.d/.extension/vscode/ms-vscode.node-debug2/
…On Thu, 5 May 2022, 12:46 Leandro Doctors, ***@***.***> wrote:
@barisere <https://github.com/barisere> said:
I fixed it by downloading the extension manually and extracting it in the
destination directory.
I'm experiencing the same problem...
@barisere <https://github.com/barisere> To which directory are you
referring to?
—
Reply to this email directly, view it on GitHub
<#554 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE4Z6BBSHOSZSFSBQZ5FLRTVIOYIVANCNFSM5M3PUDUA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
@barisere Thanks. I cannot find that directory in my |
@allentiak In my machine (I'm using Doom Emacs), the directory for a DAP extension ( To find the destination directory on your machine, try to If you cannot install the DAP extension automatically using
|
@abougouffa Thank you for your quick reply!
I tried this, with no avail. Twice, both with and without parenthesis. In both cases, I got the following:
Just in case, I made sure to add the Maybe I am missing a package, or something else? |
@allentiak Hello, I see that you are using Spacemacs, I don't know too much about how it loads packages, but I think it won't load the package until you launch a command. Try to open a project or a buffer, then launch a debug session (on Spacemacs, I think it is |
@abougouffa Actually, that's the first thing I ever tried...
Then, I get to choose the configuration template. I choose mine (see code below). launch.json {
"version": "0.2.0",
"configurations": [
{
"type": "chrome",
"request": "launch",
"name": "DAP clojurescript",
"url": "http://localhost:3000",
"sourceMaps": true,
"webRoot": "${workspaceFolder}",
"sourceMapPathOverrides": {
"*": "${workspaceFolder}/src/*"
}
}
]
} First, I get the following error:
Then, when I try evaluating the symbol, I get the following
The strangest of all is that I get the following in the
|
@yyoncho Any ideas about what all this could mean? |
@allentiak This page mentions needing
is trying to tell you. (require 'dap-chrome) Then doing the manual extension installation might work. |
@RyanCargan Thanks for your information! Unfortunately, I haven't been able to set this up... |
Going back to the original post ( tl;dr: Here's how to fix the error:
Why?it looks like the zip is empty because Which returns an error message, rather than a file
When I try and search for the package node-debug2, it doesn't seem to exist: I found this repo: https://github.com/microsoft/vscode-node-debug2 I did try building the new extension it links to: https://github.com/microsoft/vscode-js-debug/ |
UPDATE: The Chrome extension seems to download fine now :-) (However, nor the Firefox nor the Node ones can be downloaded. Haven't tried the Edge extension,though...) |
I can confirm this is broken and not an issue about dos protection. |
As @EdwardIII suggest the vscode extension |
Is the solution to this to move |
@danilevy1212 Yes, see #369. In the meantime you can manually build and install |
Thank you! |
It should be good after #700 We should migrate other packages as well (whenever possible). |
The URL seems broken again. When I execute
|
@lvguedes Assumming you cannot reopen this issue, I would suggest opening a new issue for this. |
EDIT: It's now merged Can you try the fix from here? #762 You can do it through just changing the value of the custom variable - no need to download the PR branch. |
This change fixes this error when running `(dap-node-setup)`: `url-insert-file-contents: https://open-vsx.org/api/ms-vscode/node-debug2/latest/: Not found` The problem was that the OpenVSX URL template string had a trailing slash, which is not handled by OpenVSX's Registry API Controller: https://github.com/eclipse/openvsx/blob/master/server/src/main/java/org/eclipse/openvsx/RegistryAPI.java#L348 I can't really find a blame in the OpenVSX repo which could've caused the extraneous trailing slash. Maybe the update to Java 17? As you can see, there's no trailing slash at the end, so the route doesn't get mached in the controller and causes a 404 Not Found. Just removing the slash does the job and `(dap-node-setup)` runs successfully. References: - #554 (comment) - #700
First, thank you to all the contributors for this extension. It has kept me from switching to VS Code.
I am unable to set up dap-node. It seems that the extension downloaded is broken. The logs from the Messages buffer show that the ZIP file is empty, and I confirmed that in my file manager.
dap-node: ms-vscode.node-debug2 debug extension are not set. You can download it with M-x dap-node-setup Contacting host: marketplace.visualstudio.com:443 uncompressing publicsuffix.txt.gz...done Wrote /tmp/ext83ZK7l.zip [/tmp/ext83ZK7l.zip] End-of-central-directory signature not found. Either this file is not a zipfile, or it constitutes one disk of a multi-part archive. In the latter case the central directory and zipfile comment will be found on the last disk(s) of this archive. unzip: cannot find zipfile directory in one of /tmp/ext83ZK7l.zip or /tmp/ext83ZK7l.zip.zip, and cannot find /tmp/ext83ZK7l.zip.ZIP, period. dap-node: Downloading done!
I'm be happy to provide more information if needed.
The text was updated successfully, but these errors were encountered: