"require-dependent-keys" false negative with computed decorator

[allthesignals]

The following code

import Model from 'ember-data/model';
import { attr, belongsTo } from 'ember-decorators/data';
import { computed } from 'ember-decorators/object';

export default class LayerModel extends Model {
  @belongsTo('layer-group') layerGroup
  @attr() style

  @computed('layerGroup.visible')
  get visible() {
    return true;
  }
}

Throws:

Do not use Computed Properties without dependent keys...

But a dependent key is provided.

package.json:

"ember-source": "~3.0.0",
//...
"eslint-plugin-ember-best-practices": "1.1.1",
"eslint-plugin-ember": "^5.0.0",

[allthesignals]

Maybe it's just trying to get me to use an alias there instead ;)

[runspired]

Thanks for the report! definitely seems like something we should fix :)

[allthesignals]

Added a failing test but not quite sure how to get the decorator modules imported and parsing correctly with class syntax...

[allthesignals]

Another issue I have with this is that it asks us to use init or the constructor instead (when a computed has no dep keys), but it doesn't appear that query params are applied at the moment in which they are referenced:

constructor(...args) {
  super(...args);

    // these end up being the default values, in spite of query params
   // eg '?lat=-73.94513902424359&lng=40.75213197841276&zoom=15.08183388491034'
    const mapOptions = this.getProperties('center', 'zoom', 'pitch', 'bearing');
    this.set('initMapOptions', {
      ...mapOptions,
     // other things
    });
  }
}