Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up readme #22

Merged
merged 3 commits into from
Nov 17, 2023
Merged

Clean up readme #22

merged 3 commits into from
Nov 17, 2023

Conversation

jaredgalanis
Copy link
Member

  • Some things weren't accurate anymore, so this cleans that up
  • There are too many places that describe how to spin up a local environment so this moves to pointing to the instructions in ember-jsonapi-docs

- Some things weren't accurate anymore, so this cleans that up
- There are too many places that describe how to spin up a local environment so this moves to pointing to the instructions in ember-jsonapi-docs
@jaredgalanis jaredgalanis requested a review from mansona November 10, 2023 21:32
jaredgalanis added a commit to ember-learn/ember-jsonapi-docs that referenced this pull request Nov 10, 2023
- this mostly moves the instructions about running ember-api-docs locally to that repo and points people there
- this related PR for ember-api-docs-data does the same ember-learn/ember-api-docs-data#22
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think there is just one thing left over from before

README.md Outdated Show resolved Hide resolved
@jaredgalanis jaredgalanis requested a review from mansona November 14, 2023 14:18
Copy link
Member

@mansona mansona left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jaredgalanis jaredgalanis merged commit 94f307f into main Nov 17, 2023
1 check passed
@jaredgalanis jaredgalanis deleted the jaredgalanis-patch-2 branch November 17, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants