Update config.js - label list #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
locks
reviewed
Feb 7, 2022
locks
previously approved these changes
Feb 7, 2022
|
@MelSumner can you update the test? |
MinThaMie
force-pushed
the
melsumner/update-labels
branch
from
86a494f to
5b23e8f
Compare
Updated the label list to include a variation of help wanted and one to indicate that maintainers are needed.
Discussed with @mansona to remove the strict equal in favour of checking that the property exists
MinThaMie
force-pushed
the
melsumner/update-labels
branch
from
2d0d18f to
c098508
Compare
|
so we've the general defined supportedLabels that were changed in this PR, however we use the specified supportedLabels from the ember-organisations to filter the issues again. I've not been a part of the people building this so I don't know the reason behind it, but I would suggest including the general one's from the config into the filtering on the specified ones. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the label list to include a variation of help wanted and one to indicate that maintainers are needed.