Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically align header link anchors and adapt to title size #183

Closed
IgnaceMaes opened this issue Feb 21, 2024 · 2 comments · Fixed by #200
Closed

Vertically align header link anchors and adapt to title size #183

IgnaceMaes opened this issue Feb 21, 2024 · 2 comments · Fixed by #200
Labels
good first issue Good for newcomers

Comments

@IgnaceMaes
Copy link
Member

Currently the header anchor links are the same for every title. This makes them feel small-ish on large titles, but mostly huge on small titles. This could be adapted to be made smaller for smaller titles.

A side effect of this is that it also isn't properly vertically aligned.

Example: https://guidemaker-ember-template.netlify.app/release/examples/

image
@IgnaceMaes IgnaceMaes changed the title Center header link anchors and adapt to title size Vertically align header link anchors and adapt to title size Feb 21, 2024
@IgnaceMaes IgnaceMaes added the good first issue Good for newcomers label Jun 29, 2024
@kennstenicht
Copy link
Contributor

@IgnaceMaes I think this looks better: https://deploy-preview-200--guidemaker-ember-template.netlify.app/release/examples

I don't think we have an anchor link on h1 headlines, because the article headlines don't have anchor links and we should noch use h1 inside the content to avoid multiple h1 per page.

@IgnaceMaes
Copy link
Member Author

Looks way better!

we should noch use h1 inside the content to avoid multiple h1 per page.

Exactly. We have an open issue for that as well to enforce this with markdown linting: ember-learn/guides-source#2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants