Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 0.6.2 peerDependencies: how to use with Ember 3.28? #883

Open
Gaurav0 opened this issue Nov 7, 2024 · 1 comment
Open

Version 0.6.2 peerDependencies: how to use with Ember 3.28? #883

Gaurav0 opened this issue Nov 7, 2024 · 1 comment
Labels

Comments

@Gaurav0
Copy link

Gaurav0 commented Nov 7, 2024

@ember/[email protected] requires ember-source: 4.x | 5.x as a peerDependency, making it unclear how to use version 0.6.2 of this addon with Ember 3.28. I don't see an ember-try configuration. Please clarify.

If 0.6.2 is incompatible with [email protected] it should probably have been released as 0.7.0

@SergeAstapov
Copy link
Collaborator

@Gaurav0 thank you for report! Definitely a miss, we should allow @ember/[email protected] in peerDependencies as we still test 3.28 in CI.

However, issue is not resurfaced in CI as this addon uses yarn which does not complain about such things.

As a follow up, may need to switch to pnpm with strict peer deps config to avoid such issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants