-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ember build -prod fails with broccoli-persistent-filter:CleanCSSFilter error #37
Comments
Thanks for opening this! Does your linked commit mean the bug is upstream? |
It looks like upstream Clean-CSS will not be part of ember-cli by default or at least be a separate module. I'm thinking that ember-cli-tailwind is not registered properly as a pre-processor to run before clean-css at this point. |
I ran into the same issue this evening after adding ember-cli-tailwind to my Ember 3.2.0 application and trying to run
|
Encountered this as well, brand new app. My workaround, so others don't have to search let app = new EmberApp(defaults, {
// TODO: remove when https://github.com/embermap/ember-cli-tailwind/issues/37 is fixed
minifyCSS: {
enabled: false
}
}); |
I disabled minifyCSS as well though I'd really like to not have to 😄 |
this should be reverted when embermap/ember-cli-tailwind#37 is fixed
An alternative way to get around this while still maintaining the minified css is to add the following to your "resolutions": {
"ember-cli-preprocess-registry": "3.1.0"
} There might be side effects I'm not aware of by doing this. From a fresh install production builds do not work without extra config. Is there an agreed upon fix or approach that needs to be worked on either in this addon or upstream? |
I could use some help figuring out how to best fix this bug.
|
There's an Ember CLI fix for a seemingly related issue, but I tried everything out on Ember CLI 3.4.0-beta.2 (which includes the fix) and now I'm seeing other issues. I added a comment there, let's see if anyone chimes in. As for now I'm a little lost on how to fix this. |
I had the same issue when building for production. My workaround was to actually link the <link integrity="" rel="stylesheet" href="{{rootURL}}assets/vendor.css">
+ <link integrity="" rel="stylesheet" href="{{rootURL}}assets/tailwind.css">
<link integrity="" rel="stylesheet" href="{{rootURL}}assets/frontend.css"> It might not be the best workaround, but it does the job, and the CSS is still minified. |
3.3.0 has the issue, fixed with Is it something that will be addressed in the future? |
Still facing the issue. Any better solution than not minifying CSS ? |
I'd like to move away from Sass and @import and use PostCSS for all the Tailwind inclusion stuff. Would that fix this issue? |
Ran into this now as well., ie:
By process of elimination I tracked it down to this rule:
When I swap it around, it builds fine:
Worth nothing this isnt a problem during development, only when doing prod builds.
Dono if that helps, but there ya have it! EDIT: Seems like the following also resolves it. Clearly something else happening here
Changing this to
|
app/styles/app.css
Reproduction Steps:
Workaround:
Disable minifyCSS in
ember-cli-build.js
Desired Behavior:
CSS is run through Clean-CSS after PostCSS when building for production.
The text was updated successfully, but these errors were encountered: