Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working in Ember 4 #479

Open
pjcarly opened this issue Jan 28, 2022 · 5 comments
Open

Not working in Ember 4 #479

pjcarly opened this issue Jan 28, 2022 · 5 comments

Comments

@pjcarly
Copy link

pjcarly commented Jan 28, 2022

Failing on import @ember/application/deprecations

I see it has been fixed on master branch. Can a new release be published?

@ryanto
Copy link
Member

ryanto commented Feb 15, 2022

Hey @pjcarly

I can't get tests running on master + Ember 4.0. I'm a little nervous about cutting a release w/o a working test suite.

Does your app work if you point your package.json to the github version of storefront?

@pjcarly
Copy link
Author

pjcarly commented Feb 15, 2022

It did, unfortunately I had to cancel the upgrade, as there are still many regressions in other addons that aren't working yet.

@st-h
Copy link
Contributor

st-h commented Feb 15, 2022

@ryanto I've been running the upgraded version for a couple of weeks now without issues. We might not be using all features of this addon, though. But at this point I think it is better to have a working addon for ember 4, where users might discover and report possibly existing bugs, than having a release that does not work at all. You can also create a release candidate version in order to reflect the current state and follow up with a major release later.

@ryanto
Copy link
Member

ryanto commented Feb 16, 2022

Heya Steve! Great point. I'm happy to hear you guys are able to run this in Ember 4.

I'll go ahead and get a release candidate published tomorrow and we can send the Ember 4 folks to that version.

I'll let you guys know once that's ready.

@ryanto
Copy link
Member

ryanto commented Feb 19, 2022

Ok published on npm with tag ember4.

Release here: https://github.com/embermap/ember-data-storefront/releases/tag/v0.18.2-ember4.0

Thanks for the feedback everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants