-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Not working in Ember 4 #479
Comments
Hey @pjcarly I can't get tests running on master + Ember 4.0. I'm a little nervous about cutting a release w/o a working test suite. Does your app work if you point your package.json to the github version of storefront? |
It did, unfortunately I had to cancel the upgrade, as there are still many regressions in other addons that aren't working yet. |
@ryanto I've been running the upgraded version for a couple of weeks now without issues. We might not be using all features of this addon, though. But at this point I think it is better to have a working addon for ember 4, where users might discover and report possibly existing bugs, than having a release that does not work at all. You can also create a release candidate version in order to reflect the current state and follow up with a major release later. |
Heya Steve! Great point. I'm happy to hear you guys are able to run this in Ember 4. I'll go ahead and get a release candidate published tomorrow and we can send the Ember 4 folks to that version. I'll let you guys know once that's ready. |
Ok published on npm with tag Release here: https://github.com/embermap/ember-data-storefront/releases/tag/v0.18.2-ember4.0 Thanks for the feedback everyone. |
Failing on import
@ember/application/deprecations
I see it has been fixed on master branch. Can a new release be published?
The text was updated successfully, but these errors were encountered: