Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove implicit injection #485

Open
locks opened this issue Apr 21, 2022 · 0 comments · May be fixed by #490
Open

Remove implicit injection #485

locks opened this issue Apr 21, 2022 · 0 comments · May be fixed by #490

Comments

@locks
Copy link

locks commented Apr 21, 2022

This addon is using a deprecated functionality in the inject-storefront which causes problems in Ember 4.0.
The path forward here is to remove the instance initializer and have the users explicitly inject the service as necessary.

Context:
@gilest gilest linked a pull request Nov 23, 2022 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove implicit injection gilest/ember-data-storefront
1 participant
@locks