Further Review - Simplification of some code #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emhane
reviewed
Jan 17, 2024
emhane
reviewed
Jan 17, 2024
emhane
reviewed
Jan 17, 2024
emhane
requested changes
Jan 18, 2024
Co-authored-by: Emilia Hane <[email protected]>
Co-authored-by: Emilia Hane <[email protected]>
Co-authored-by: Emilia Hane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that we now do two similar requests, where we as the service for an ENR.
We do it for the WhoAreYouRef and for the HolePunch.
I thought it might be nice to just group these and make it more accessible if in the future we need to do it again. So I made a singular
RequestEnrandEnrResponsein the Handler API, which handles both cases.In the process I reviewed some more code and found I could simplify it a bit. I've reduced a lot of the nat code, down to just a single
Natstruct, which makes the naming a bit nicer and the code easier to manage.Again I think I have changed no functionality, but reduced the code and simplified the naming.
This builds on top of the previous PR. So the diff will be easier to see once we merge the other one in.