Add our own kodiutils library #174
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dagwieers
force-pushed
the
kodiutils
branch
from
e8fda2f to
fd2e0a6
Compare
dagwieers
referenced
this pull request
Sep 16, 2019
dagwieers
force-pushed
the
kodiutils
branch
19 times, most recently
from
0e78054 to
ea821b7
Compare
This PR includes: - Introduce a kodiutils library - Import some library to blocks where they are needed - Import only the stuff we need from libraries - Add proxy-support testing
dagwieers
force-pushed
the
kodiutils
branch
from
ea821b7 to
a9af351
Compare
Is this the reason I get |
|
@mediaminister We test both with and without proxy. In fact all tests run without proxy, but I do an x64 test with proxy. You only need to install proxy.py ( |
dagwieers
force-pushed
the
kodiutils
branch
from
b4e58ac to
a2e4664
Compare
dagwieers
force-pushed
the
kodiutils
branch
from
a2e4664 to
4e13631
Compare
|
Looks good to me. |
dagwieers
force-pushed
the
kodiutils
branch
from
9e2ca88 to
bca8461
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes:
This relates to #94 and #89