Problem with Renoir Try/Except

[KellerKev]

Could you help me with the following problem:

The following template code used to work with yatl:

<div class="columns">
      [[try:]]
        [[if level == 'manager':]]
          [[include 'manager_menu.html']]
          <div class="column is-10">
            <div class="box">
                [[include]]
            </div>
          </div>

        [[elif level == "admin":]]
          [[include 'admin_menu.html']]
          <div class="column is-10">
            <div class="box">
              [[include]]
            </div>
          </div>

        [[else:]]
        <div class="column is-12">
          [[include]]
        </div>
        [[pass]]
      [[except:]]
          <div class="column is-12">
            [[include]]
          </div>
      [[pass]]

with Renoir I get the following error:

return self._render(source, file_path, context)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/apis.py", line 191, in _render
    code, content = self.parse(file_path, source, context)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/apis.py", line 160, in parse
    parser = self.parser_cls(
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/parsers.py", line 71, in __init__
    self.parse(text)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/parsers.py", line 174, in parse
    ctx.parse()
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/stack.py", line 235, in parse
    self.parser.parse_python_block(self, element)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/parsers.py", line 145, in parse_python_block
    self._parse_python_line(ctx, element, line.strip())
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/parsers.py", line 133, in _parse_python_line
    lexer(ctx, value=value)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/lexers.py", line 27, in __call__
    self.process(ctx, value)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/lexers.py", line 121, in process
    ctx.state.injections.pop(ctx.state.parent._id)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/lexers.py", line 112, in process
    ctx.parse()
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/stack.py", line 235, in parse
    self.parser.parse_python_block(self, element)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/parsers.py", line 145, in parse_python_block
    self._parse_python_line(ctx, element, line.strip())
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/parsers.py", line 133, in _parse_python_line
    lexer(ctx, value=value)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/lexers.py", line 27, in __call__
    self.process(ctx, value)
  File "/home/ubuntu/Development/pygit_dev2/lib/python3.8/site-packages/renoir/parsing/lexers.py", line 92, in process
    ctx.state.implicit_extenders.pop(extend_src._id)
KeyError: '5378fda3f1c74a558cab05f539184072

[gi0baro]

The issue seems to be the usage of include inside try-except blocks. Renoir parsing engine works kinda like a state machine, thus an exception outside the rendering context won't undo the processed blocks.

Can I ask you why wrapping the entire logic in a try-except block? If I got the point you can't be sure level is defined. If that's the case, I suggest you to workaround the issue with something like:

[[ level = globals().get("level", None) ]]

before the if block.

Also, please open up an issue for this on the renoir repo, but mind that it will probably require quite a lot of work to be fixed.

[KellerKev]

Thanks Giovanni. The use case is to use different includes depending on the users role. The same issue happens when I use a if/then/else logic. Still trying your workaround too.

Porting a fairly big application from yatl to renoir the relies on the includes with conditions depending on the users role.
Its an important part.

So far I am not so confident I can work around it .

Maybe you could look into a fix for Renoir please?

I would appreciate it a lot.

Happy to open that issue ticket.

Thanks.

[gi0baro]

@Kkeller83 what I meant is that the issue regards include instructions without values. Can you try with the following and let me know if it works?

[[ level = globals().get("level", None) ]]
<div class="columns">
[[ col = 10 ]]
[[ if level == 'manager': ]]
  [[ include 'manager_menu.html' ]]
[[ elif level == 'admin': ]]
  [[ include 'admin_menu.html' ]]
[[ else: ]]
 [[ col = 12 ]]
[[ pass ]]
  <div class="column is-[[ =col ]]">
    [[ if col == 10: ]]
    <div class="box">
    [[ pass ]]
    [[ include ]]
    [[ if col == 10: ]]
    </div>
    [[ pass ]]
  </div>

I know is counter-intuitive, but at least we can confirm is include related.

[KellerKev]

Thanks! I did try it but I got the same error :(