Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A humble request to update the renderer after VRS got updated to v1.5 in nvidia driver v545.84 #21

Open
geahad opened this issue Oct 21, 2023 · 2 comments

Comments

@geahad
Copy link

geahad commented Oct 21, 2023

Fristly, thank you very much for producing this in the first place!

I'm no dev, so I'm just guessing, but I've noticed the following after the update:

-- VRS now engages in Firefox, Edge and Chrome even if my desktop is in HDR mode (did only ever engage when in SDR in VRS v1.0)
-- VRS now engages in the mentioned browsers even at native resolution (obviously lower banding etc. is observerd when played in-browser)

The two aforementioned things are not functional in the current build of this fork of VideoRenderer. I suspect it's because (if I remember correctly) there were a number of problems getting it engaged in the first place, so code execution safeguards were implemented to prevent it from running if HDR mode is detected, and (probably) when the video file's resolution is equal to desktop resolution.

I know that probably not many people use MPC-HC or MPC-BE, but alas I was very, very happy when this renderer was made to use VRS. Perhaps I'm asking too much. I don't know -- I just do know that, if VideoRenderer could be augmented with the new v1.5 VRS functionality, It'd mean a lot! Thanks for reading! Cheers!

@clsid2
Copy link

clsid2 commented Oct 21, 2023

The official development repository for this renderer is here:
https://github.com/Aleksoid1978/VideoRenderer

@geahad
Copy link
Author

geahad commented Oct 21, 2023

The official development repository for this renderer is here: https://github.com/Aleksoid1978/VideoRenderer

I have now read the changelog for the linked repository.

Was not aware that your contribution (fork) was integrated into the main branch. Somehow thought your fork was the only one supporting VRS.

Understood. I will ask there. Thank you for pointing me in the right direction! Cheers!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants