add RTX video enhancement HDR to MPC video renderer. #24
Comments
|
I'm looking forward to integrating this feature as well. |
|
The build at Aleksoid1978#116 (comment) appears to support it, not sure if it's working as well as in chrome/edge though. |
|
I knew you would come to the rescue! many many thanks for putting in the time and work. Will try it! Cheers |
I tried this test build and works just as well as in chrome. However it washes out the colors if the video is already in HDR format. |
|
@Naboum could you see if this build works any better? Added a check so RTX HDR is only enabled if source video isn't HDR: |
I've tested this version and it correctly distinugishes between native-hdr video files and sdr-ones. Well done! Btw. thank you SO much for making this happen! <3 |
It now works correctly, thank you. |
|
Glad to hear, pushed 1.1 release at https://github.com/emoose/VideoRenderer/releases/tag/rtx-hdr-1.1 which includes the change along with a fix to let VSR work up to 1440p |
|
There seems to be one little caveat though (but that one's on nvidia): Also, if I may ask for a little something more: the latest versions of the renderer have options to select above which resolution VSR should kick-in. The highest available from the drop down is "eqal to or lower than 1080p". I'm on a 2160p display and actually liked using VSR to upscale from 1440p also (is offciially supported, worked in previous versions). Could that ("equal to or lower than 1440p) option be added to the drop down? |
|
Ahaha, sorry... Haven't seen you've already integrated tha 1440p thing already... You work very quickly :-D |
I played a 4K native-hdr video in fullscreen and the colors are again washed out. However in windowed mode it works great. It only happens when Super Resolution is enabled in the settings. EDIT : same thing happens when playing a 720p native-hdr video while in fullscreen and Super Resolution setting set to <= HD or higher, and when playing a 1080p native-hdr video while in fullscreen and Super Resolution setting set to <= Full HD or lower. |
If you try playing a native hdr 1080p video on youtube with a 4K monitor, with both VSR and HDR enabled in Nvidia control panel, the colors aren't washed out. Does that mean VSR is automatically disabled by chrome during this scenario ? EDIT : |
|
Also observe issues with colors, but in my case they are bleak in the "HDR Off" mode. |
|
The RTX HDR seems to be breaking when watching SDR 10-bit content 10-bit video After converting the file to 8-bit the HDR works as expected EDIT: tried loading the file in a browser video player extension and the HDR doesn't seem to kick in when loading 10 bit content (it works for the 8-bit version in the extension as well, so I guess 10 bit is not supported) |
|
Hmm, guess maybe we should only try enabling superres for non-native-HDR content seeing as NV mention that VSR doesn't support HDR, and should also only enable RTX HDR when it's a HDR display.
Ah nice was just going to ask if you could try that, yeah would guess it probably doesn't like 10-bit, I'll see if I can add a check to only enable for 8-bit formats (if you change your internal filters > video decoder settings in MPC then it should be able to convert 10-bit to 8-bit automatically) E: here's a build with those changes: |
Weird. NCP reports that HDR Video Enhancement is off when playing 10-bit video in MPC, but it still looks like the first image in my last post Rolled back to version 1.1 and the same happens there, NCP reports HDR Video Enhancement off, but the player still outputs a broken HDR image Also tried opening the file with the stock Video Renderer from Aleksoid1978 to check if there was something broken with the player always showing 10bit video as HDR, but the video plays fine there |
|
Oh might have an idea what it is, for RTX HDR to work this removed a check for it being HDR source so it'd use right color space, with SDR it works fine since RTX HDR will convert it, but since RTX doesn't handle 10-bit I guess that makes it use the wrong colors. Maybe this build can fix it, should only use that color space if it's HDR or 8-bit: |
Seems to be working fine now! |
|
Hi, I have a weir problem in MPC-BE x64 1.6.11, HDR and Super Resolution work when windowed, but when going fullscreen it works when the OSD is visible, once it disappear both get disabled. I tried disabling the OSD, it's worse, going fullscreen when the video is playing just gives a black screen and I have to reload the video to get it to work again. I tried the 1.1 and 1.2-test2 and got the same issue. EDIT : looks like an NVidia issue, it does the same in the browser now, on Youtube it works until the UI disappears, something broke I don't know how. |
|
@Raxcoms |
|
@Naboum weird. I have two 10-bit files and neither work for me Media info 1: link Also both give me the broken hdr output |
|
still getting overblown out colors playing 10 bit hevc videos with test 2 myself |
|
@Raxcoms What do you mean by "they cant be played" ? You can't drag and drop the file to a new tab ? Are they mkv ? |
|
Yes, they are .mkv files |
Seems one of the color depth checks I added wasn't working right since the depth value wasn't setup yet, hopefully this build fixes that:
E: oh might have figured out RTXHDR for 10-bit SDR now, just had to loosen some of the checks I'd added. E2: removed some redundant code I'd added: E3: one more test build, this should be able to disable all the autoHDR stuff if it failed to be enabled (eg. old driver ver, or not NV card), should now reinit with correct colors instead of still using HDR colorspace: Posted release at https://github.com/emoose/VideoRenderer/releases/tag/rtx-hdr-1.2 |
|
works now 👍 |
|
if i select 8 bit texture format on an 8 bit video the colors are still screwed up and it reports rtx hdr as inactive. It activates fine if i choose 10 or 16 though |
Chrome doesn't like mkv, you have to convert it to mp4 |
My .mkv 10-bit files are playing with auto HDR properly now! |
|
Would be kinda cool if it worked for image inputs as well. |
|
I tested all the output formats in the LAV video decoder settings and only these work perfectly My MPC Renderer settings are Most of the other formats have messed up colors like Tested on the HEVC YUV444 10 bit format trailer of Argylle downloaded from https://thedigitaltheater.com/argylle-2024/ I tested this by enabling only one of the output format options at a time and playing the trailer, the results for forcing conversion each of these output formats is posted below Hope it helps in the development or configuration for someone. |
|
AYUV gives bad performance and should always be UNchecked like it is by default. Thanks for testing. Emoose should add a check to only allow RTXHDR for NV12/P010/YUY2. Those colorspaces are used in 99% of all cases anyway. |
|
@GautamtmD thanks for looking into them, any chance you could try some of the broken ones with the build at #26 (comment)? Maybe possible that MPCVR was trying to convert them and breaking since that was missing. E: ah I missed the download link in your post, seems to give the same results as you had, too bad. Will add the checks clsid2 suggested in next release. |
|
Hello! Would it be possible/feasable to add some image tweaking sliders (for contrast, gamma, saturation, peak nits and paper white) for RTX HDR in this renderer, like you've done for this project: emoose/DLSSTweaks#120 ? I've tried putting the x64 version of the provided asi loader, tried renaming it into the suggested possible names and all, and then, as per instructions, put it into the folder where mpc-hc64.exe is, but alas, it crashes, and thus (as expected) is not compatible with non-games... That would be, like, beyond awesome. |
Seems there's no effect with it atm though, guess the way they configure Video HDR is probably different to how TrueHDR works. Does it make any truehdrtweaks.log file for you? If it doesn't maybe try running it as admin instead. E: yep, seems video HDR settings get inited in a different part, looks like it does take same kind of parameters as TrueHDR does though, hopefully can find a way to adjust them soon. Also looks like VideoHDR does actually update the nits/contrast/saturation/paperwhite TrueHDR settings based on your display, not really sure where it pulls all the values for them yet though. |
|
Just posted tweaks 0.5 at https://www.nexusmods.com/site/mods/781 which seems to work with VideoHDR now, tried running it a couple times and couldn't make it crash anymore neither, if you still have any issues let me know. |
I have tested this version, and it indeed loads and almost all function-identified ini parameters works as advertised. The cvar that makes the picture go bananas is the one for peak nits. It seems this one needs to be left alone at "-1", |
|
Huh didn't notice a green line on my end, did you rename the winmm.dll at all? It could be the saturation/contrast values that come pre-overridden in the INI too, maybe setting those to -1 would help. I posted 0.5.1 to help fix a DX9 issue, probably won't make much difference but worth a try if you haven't already. |
Thank you for the suggestions. The setting "Contrast = 1.0" was the culprit for the green line. Interestingly enough, as soon as I set it to anything above 1.0 (i.e. even "1.01") the green line goes away. Very peculiar indeed. Thank you, now it's perfectly usable. Cheers! |
Glad to hear, I did just run into the green line issue earlier after posting too, as you said changing contrast seems to fix it, kinda odd that it would cause something like that, haven't seen it in any games yet at least. BTW it seems a lot of people measured VideoRTX at 650nits, and grabbing the settings VideoRTX sets up it does seem to set PeakBrightness to 650 for me on a 1000nit display, seems the 650 number is taken from somewhere else though, not sure if it's just 65% of display nits, or maybe VideoRTX has its own settings data which this copies from - if it's the latter maybe there's some way to change it from the player, hm... |
|
@emoose |
|
Hello! The only tangible difference between the last version emoose posted (https://github.com/emoose/VideoRenderer/releases/tag/rtx-hdr-1.2) and the last two ones offered for download with MPC-HC v2.1.5 (MPCVideoRenderer_0.7.2.2195) and v2.1.6 (MPCVideoRenderer_0.7.2.2203) is that they don't engage superresolution for resolutions larger than 1080p. No biggie in the end, but for me personally, it's the only reason why I'm still sticking with v1.2. |
|
Hi! How do i disable rtx hdr for native 10 bit hdr content? It seems to be in use according to high gpu usage. |
Can this solution lead to problems with other types of videos or greater energy consumption? |
|
Yes, it will lead to problems with HDR and it should also not be needed anymore. These are outdated comments for outdated driver for outdated fork of the renderer. |
Turn off "Auto HDR" in windows. This fixed it for me. |
RTX video enhancement HDR was added to driver version 551.23. It's an AI powered feature just like super resolution.
It can be enabled on the nvidia control panel and it needs requesting the feature from the renderer.
https://blogs.nvidia.com/blog/rtx-video-hdr-remix-studio-driver/
https://www.tomshardware.com/pc-components/gpu-drivers/nvidia-adds-ai-powered-sdr-to-hdr-video-enhancement-to-its-latest-drivers-rtx-video-hdr-now-available-for-all-rtx-owners
The text was updated successfully, but these errors were encountered: