Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

View FileSet: Single-Use Links errors #710

Closed
eporter23 opened this issue Jan 15, 2025 · 5 comments
Closed

View FileSet: Single-Use Links errors #710

eporter23 opened this issue Jan 15, 2025 · 5 comments
Assignees
Labels
bug Something isn't working question Further information is requested Samvera Issues related to Samvera stack

Comments

@eporter23
Copy link
Contributor

Describe the bug
When attempting to use the standard Create Single-Use Link function in the View FileSet page, multiple odd behaviors occur when creating and deleting these. This is occurring in oe24-test at present.

To Reproduce
Steps to reproduce the behavior:

  1. Login as Admin user
  2. Go to a FileSet page
  3. Click on the Create Single-Use link button
  4. Wait and/or refresh the screen (there can be a several minute delay)
  5. Click on the Single-Use links dropdown
  6. See that 2 links have been created
  7. Click on the first entry and try to delete it
  8. See routing error

Expected behavior
A clear and concise description of what you expected to happen.

These links should get created quickly. Only one link should be created at a time (not 2). Deleting a link should not return an error.

Screenshots
If applicable, add screenshots to help explain your problem.

Screenshot 2025-01-15 at 8.51.04 AM.png

Screenshot 2025-01-15 at 8.49.14 AM.png

Desktop (please complete the following information):

  • OS: Mac OS 14.7.1
  • Chrome (latest)

Additional context
Add any other context about the problem here.

Using the link generated does seem to function (so that portion is working)

@eporter23 eporter23 added bug Something isn't working question Further information is requested Samvera Issues related to Samvera stack labels Jan 15, 2025
@bwatson78 bwatson78 self-assigned this Jan 16, 2025
@eporter23
Copy link
Contributor Author

@bwatson78 if this is a huge lift to fix, let me know and we can report it to Samvera (assuming it's a Sirenia-related issue)

@bwatson78 bwatson78 self-assigned this Jan 22, 2025
@bwatson78
Copy link
Contributor

Just tested this in Test with https://oe24-test.libraries.emory.edu/concern/parent/a8e24b23-58cb-4b31-b551-248d951bbad3/file_sets/a2ca3256-6708-4caf-a270-e80b631de6d9. I only see one link in the pull down list and I definitely get the route mismatch error after attempting to delete. From the error page, I can tell that the route is matched to the DELETE action and the link is routing to GET. If the link code is exposed in our application, it should be easy to fix. Checking that now.

@bwatson78
Copy link
Contributor

#720

@bwatson78
Copy link
Contributor

Hyrax PR: samvera/hyrax#6990

@eporter23
Copy link
Contributor Author

Just deleted 3 links and all looks good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working question Further information is requested Samvera Issues related to Samvera stack
Projects
None yet
Development

No branches or pull requests

2 participants