Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRR-4833: Make pageIndicatorPosition prop in PageViews component public #1757

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

juwonjeong
Copy link
Contributor

Enact-DCO-1.0-Signed-off-by: Juwon Jeong ([email protected])

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Make pageIndicatorPosition prop in PageViews component public as UX guide is updated.

Resolution

Updated docs and sampler
Added changelog

Additional Considerations

Links

WRR-4833

Comments

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.89%. Comparing base (3df84eb) to head (56bf2b2).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1757   +/-   ##
========================================
  Coverage    80.89%   80.89%           
========================================
  Files          148      148           
  Lines         6672     6672           
  Branches      1988     1988           
========================================
  Hits          5397     5397           
  Misses         967      967           
  Partials       308      308           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant