use asyncio.run(..., loop_factory) to avoid asyncio.set_event_loop_policy #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graingert
force-pushed
the
avoid-set-event-loop-policy
branch
from
ee26ddb
to
12c6f54
Compare
graingert
commented
Oct 15, 2023
|
|
||
| import uvloop | ||
|
|
||
|
|
||
| def uvloop_setup(use_subprocess: bool = False) -> None: | ||
| asyncio.set_event_loop_policy(uvloop.EventLoopPolicy()) |
There was a problem hiding this comment.
uvloop.EventLoopPolicy is deprecated
graingert
commented
Oct 15, 2023
uvicorn/loops/asyncio.py
Outdated
|
|
||
| logger = logging.getLogger("uvicorn.error") | ||
|
|
||
|
|
||
| def asyncio_setup(use_subprocess: bool = False) -> None: | ||
| if sys.platform == "win32" and use_subprocess: | ||
| asyncio.set_event_loop_policy(asyncio.WindowsSelectorEventLoopPolicy()) |
There was a problem hiding this comment.
set_event_loop_policy will be deprecated in python 3.13
|
This still needs a doc change |
|
actually this doesn't need a doc change as |
Kludex
force-pushed
the
avoid-set-event-loop-policy
branch
from
f6f7a27
to
6450a87
Compare
Kludex
force-pushed
the
avoid-set-event-loop-policy
branch
from
6450a87
to
849169f
Compare
Kludex
approved these changes
Aug 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
set_event_loop_policy will be deprecated in python 3.13 and uvloop.EventLoopPolicy is deprecated already, this backports and uses the preferred
loop_factorykeyword to configure asyncio.runChecklist