Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deploying FastAPI in AWS behind an AWS Load Balancer I hit a roadblack to trust the proxy (the Load Balancer): I know its network but not its IPs. Using
ProxyHeadersMiddleware
as it is, I'd have to know those IPs beforehand to trust them.Would you be willing to consider a slight modification to
ProxyHeadersMiddleware
to accepttrusted_networks
in addition totrusted_hosts
?Attached is some working code of how it would work.
Checklist
PS: I've opened a discussion, you can close this PR in the meantime if needed, it'll still reference some code ideas.